Find image from bindata csvs based on container name instead of order#1555
Merged
openshift-merge-bot[bot] merged 1 commit intoAug 7, 2025
Merged
Conversation
Using the order in the list of containers is fragile as it can change based on implementation details as kustomization syntax of the service operators. This patch is moving to use the container name of the operator manager which should be consistent and deterministic. Signed-off-by: Alfredo Moralejo <amoralej@redhat.com>
Contributor
|
/test openstack-operator-build-deploy-kuttl |
Contributor
Author
|
/test functional |
Contributor
|
/test openstack-operator-build-deploy-kuttl |
abays
approved these changes
Aug 7, 2025
abays
left a comment
abays
left a comment
Contributor
There was a problem hiding this comment.
Tested locally and works.
This will allow us to update all our services operators and remove deprecated Kustomize fields which currently cause them to place the controller-manager container after the kube-rbac-proxy one.
/lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, amoralej The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 1483c08
into
openstack-k8s-operators:main
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the order in the list of containers is fragile as it can change based on implementation details as kustomization syntax of the service operators.
This patch is moving to use the container name of the operator manager which should be consistent and deterministic.